Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/orderbook: Update orderbook benchmark to use liquidity pools from history archives #4091

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Nov 22, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Update orderbook benchmark to use liquidity pools from history archives.

Why

Now that protocol 18 has been live there have been lots of pools created. We can use data from recent ledgers to run our benchmarks for the path finding algorithm.

Known limitations

[N/A]

@tamirms tamirms requested a review from a team November 22, 2021 09:46
@tamirms tamirms merged commit da266e0 into stellar:master Nov 23, 2021
@tamirms tamirms deleted the orderbook-benchmarks branch November 23, 2021 08:03
erika-sdf pushed a commit to erika-sdf/go that referenced this pull request Dec 3, 2021
… history archives (stellar#4091)

Update orderbook benchmark to use liquidity pools from history archives and report memory allocations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants