Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Implement horizon db fill-gaps command #4060

Merged
merged 6 commits into from
Nov 10, 2021

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Nov 9, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Close #4010

horizon db fill-gaps can be called with no parameters in which case it queries for any existing gaps in the horizon db and then proceeds to ingest history to fill the gaps.

The command can also be called with a start and end ledger parameter. In which case, the command will only query for gaps within the provided range.

horizon db fill-gaps 1 1000 will fill any gaps occurring within the range 1-1000

It is also possible to configure the same parallel worker command line parameters that are used by horizon db reingest range so that fill-gaps can be also take advantage of concurrency.

Known limitations

[N/A]

@tamirms tamirms requested a review from a team November 9, 2021 12:25
services/horizon/cmd/db.go Outdated Show resolved Hide resolved
services/horizon/internal/ingest/main.go Outdated Show resolved Hide resolved
services/horizon/internal/ingest/parallel.go Outdated Show resolved Hide resolved
@tamirms
Copy link
Contributor Author

tamirms commented Nov 9, 2021

@bartekn can you take another look?

@tamirms tamirms merged commit 371f727 into stellar:master Nov 10, 2021
@tamirms tamirms deleted the fill-gaps branch November 10, 2021 11:59
tamirms added a commit that referenced this pull request Dec 6, 2021
…llel-workers (#4127)

#4060 introduced a bug where command line flags such as --parallel-workers are not getting parsed when running the horizon db reingest range command. This commit fixes this bug so that all the reingest range command line flags are parsed correctly for both the reingest range command and the fill-gaps command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: add horizon db reingest fill-gaps command
2 participants