Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/friendbot: remove disabled error messages that is dead code #4059

Merged
merged 2 commits into from
Nov 9, 2021
Merged

services/friendbot: remove disabled error messages that is dead code #4059

merged 2 commits into from
Nov 9, 2021

Conversation

leighmcculloch
Copy link
Member

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove the error messages for when friendbot is disabled.

Why

Friendbot is never disabled. The field that this code checks is always set with a value, and so the error is never triggered. I think this code is old code that is probably from the days when friendbot was a part of Horizon and could be disabled within Horizon. Now the code is always enabled because for networks that don't have friendbot functionality we simply don't deploy friendbot.

Known limitations

N/A

@leighmcculloch leighmcculloch requested review from bartekn and a team and removed request for bartekn November 9, 2021 04:49
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leighmcculloch leighmcculloch merged commit 30b2402 into stellar:master Nov 9, 2021
@leighmcculloch leighmcculloch deleted the friendbotalwaysenabled branch November 9, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants