Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Remove --captive-core-reuse-storage-dir #4048

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

erika-sdf
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove --captive-core-reuse-storage-dir flag from Horizon.

Why

The flag was introduced to provide a workaround to stellar core leaving directories corrupt. Since this has since been fixed, this flag is no longer needed.

Known limitations

N/A

@erika-sdf erika-sdf linked an issue Nov 4, 2021 that may be closed by this pull request
@erika-sdf erika-sdf force-pushed the reuse branch 2 times, most recently from e783bdc to 9564e7f Compare November 5, 2021 00:39
@erika-sdf erika-sdf requested review from bartekn and Shaptic November 5, 2021 00:55
@erika-sdf erika-sdf marked this pull request as ready for review November 5, 2021 00:56
@erika-sdf erika-sdf merged commit ef33e4c into stellar:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove --captive-core-reuse-storage-dir flag
3 participants