services/horizon: Add ledger_fetch_duration_seconds metric #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
reviewed
Oct 20, 2021
| @@ -480,7 +483,7 @@ func (r resumeState) run(s *system) (transition, error) { | |||
| log.WithError(err).Warn("error updating stellar-core cursor") | |||
| } | |||
|
|
|||
| duration := time.Since(startTime).Seconds() | |||
| duration = time.Since(startTime).Seconds() | |||
There was a problem hiding this comment.
Is this intentionally from startTime (I think yes but making sure)? It could also be from the last duration, to measure time since the last metric and separate fetch from ingest.
There was a problem hiding this comment.
startTime is actually updated in line 451 (old code)/454 (new code) above.
2opremio
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add
horizon_ingest_ledger_fetch_duration_secondsmetric indicating time required to fetch a ledger fromLedgerBackend.Why
We don't track this value outside logging but it can be useful (ex. alerting if ledger backend is slow).
Known limitations
[TODO or N/A]