Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add state_verify_ledger_entries_count metric #4015

Merged
merged 2 commits into from
Oct 21, 2021
Merged

services/horizon: Add state_verify_ledger_entries_count metric #4015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d8a33f
services/horizon: Add state_verify_ledger_entries_count metric
bartekn Oct 19, 2021
a6307ec
move
bartekn Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions services/horizon/internal/ingest/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ type Metrics struct {
// 0 otherwise.
StateInvalidGauge prometheus.GaugeFunc

// StateVerifyLedgerEntriesCount exposes total number of ledger entries
// checked by the state verifier by type.
StateVerifyLedgerEntriesCount *prometheus.SummaryVec

// LedgerStatsCounter exposes ledger stats counters (like number of ops/changes).
LedgerStatsCounter *prometheus.CounterVec

Expand Down Expand Up @@ -315,6 +319,16 @@ func (s *system) initMetrics() {
},
)

s.metrics.StateVerifyLedgerEntriesCount = prometheus.NewSummaryVec(
prometheus.SummaryOpts{
Namespace: "horizon", Subsystem: "ingest", Name: "state_verify_ledger_entries_count",
Help: "number of ledger entries downloaded from buckets in a single state verifier run",
// Quantile ranks are not relevant here so pass empty map.
Objectives: map[float64]float64{},
},
[]string{"type"},
)

s.metrics.LedgerStatsCounter = prometheus.NewCounterVec(
prometheus.CounterOpts{
Namespace: "horizon", Subsystem: "ingest", Name: "ledger_stats_total",
Expand Down
17 changes: 15 additions & 2 deletions services/horizon/internal/ingest/verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"time"

"github.com/guregu/null"
"github.com/prometheus/client_golang/prometheus"

"github.com/stellar/go/ingest"
"github.com/stellar/go/services/horizon/internal/db2"
Expand Down Expand Up @@ -124,13 +125,19 @@ func (s *system) verifyState(verifyAgainstLatestCheckpoint bool) error {
}
}

totalByType := map[string]int64{}

startTime := time.Now()
defer func() {
duration := time.Since(startTime).Seconds()
if updateMetrics {
// Don't update metrics if context cancelled.
if s.ctx.Err() != context.Canceled {
s.Metrics().StateVerifyDuration.Observe(float64(duration))
for typ, tot := range totalByType {
s.Metrics().StateVerifyLedgerEntriesCount.
With(prometheus.Labels{"type": typ}).Observe(float64(tot))
}
}
}
log.WithField("duration", duration).Info("State verification finished")
Expand All @@ -150,7 +157,7 @@ func (s *system) verifyState(verifyAgainstLatestCheckpoint bool) error {
}

assetStats := processors.AssetStatSet{}
total := 0
total := int64(0)
for {
var keys []xdr.LedgerKey
keys, err = verifier.GetLedgerKeys(verifyBatchSize)
Expand All @@ -172,16 +179,22 @@ func (s *system) verifyState(verifyAgainstLatestCheckpoint bool) error {
switch key.Type {
case xdr.LedgerEntryTypeAccount:
accounts = append(accounts, key.Account.AccountId.Address())
totalByType["accounts"]++
case xdr.LedgerEntryTypeData:
data = append(data, *key.Data)
totalByType["data"]++
case xdr.LedgerEntryTypeOffer:
offers = append(offers, int64(key.Offer.OfferId))
totalByType["offers"]++
case xdr.LedgerEntryTypeTrustline:
trustLines = append(trustLines, *key.TrustLine)
totalByType["trust_lines"]++
case xdr.LedgerEntryTypeClaimableBalance:
cBalances = append(cBalances, key.ClaimableBalance.BalanceId)
totalByType["claimable_balances"]++
case xdr.LedgerEntryTypeLiquidityPool:
lPools = append(lPools, key.LiquidityPool.LiquidityPoolId)
totalByType["liquidity_pools"]++
default:
return errors.New("GetLedgerKeys return unexpected type")
}
Expand Down Expand Up @@ -217,7 +230,7 @@ func (s *system) verifyState(verifyAgainstLatestCheckpoint bool) error {
return errors.Wrap(err, "addLiquidityPoolsToStateVerifier failed")
}

total += len(keys)
total += int64(len(keys))
localLog.WithField("total", total).Info("Batch added to StateVerifier")
}

Expand Down