Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Batch claimable balance creation, updates and deletions #3953

Merged

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Sep 22, 2021

Also, avoid passing XDR ledger entries and XDR Claimable Balance IDs to the claimable balance DB interface

Closes #3930
Closes #3936

@2opremio 2opremio requested a review from bartekn September 22, 2021 15:10
@2opremio 2opremio force-pushed the 3930-batch-cb-creation-updates-and-deletions branch from 35ece37 to 15ed757 Compare September 22, 2021 15:24
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added one suggestion about BalanceID.

Also, avoid passing XDR ledger entries to the claimable balance DB interface
@2opremio 2opremio force-pushed the 3930-batch-cb-creation-updates-and-deletions branch 2 times, most recently from cbaa215 to 3fe6734 Compare September 23, 2021 14:35
@2opremio 2opremio force-pushed the 3930-batch-cb-creation-updates-and-deletions branch from 3fe6734 to a70fcfa Compare September 23, 2021 15:36
@2opremio 2opremio merged commit e24fae3 into stellar:master Sep 23, 2021
@2opremio 2opremio deleted the 3930-batch-cb-creation-updates-and-deletions branch September 23, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants