services/horizon: Split App.UpdateLedgerState into Core and Horizon ledger update methods #3900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit splits
UpdateLedgerState
intoUpdateCoreLedgerState
andUpdateHorizonLedgerState
which update Core and Horizon ledger state separately. It also changesTick
frequency to 5 seconds.Close #3883.
Why
If Stellar-Core is unresponsive the call to Stellar-Core
/info
endpoint will be cancelled after 10 seconds but it will also return entireUpdateLedgerState
method. This will make Horizon ledgers stats out of date which can affect streaming (because streams are updated only when Horizon ledger inledger.Status
is incremented.Known limitations
With this change it's possible that Horizon root can report Core ledger sequence behind Horizon.