Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Split App.UpdateLedgerState into Core and Horizon ledger update methods #3900

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Sep 8, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit splits UpdateLedgerState into UpdateCoreLedgerState and UpdateHorizonLedgerState which update Core and Horizon ledger state separately. It also changes Tick frequency to 5 seconds.

Close #3883.

Why

If Stellar-Core is unresponsive the call to Stellar-Core /info endpoint will be cancelled after 10 seconds but it will also return entire UpdateLedgerState method. This will make Horizon ledgers stats out of date which can affect streaming (because streams are updated only when Horizon ledger in ledger.Status is incremented.

Known limitations

With this change it's possible that Horizon root can report Core ledger sequence behind Horizon.

@bartekn bartekn requested a review from a team September 8, 2021 13:20
@bartekn bartekn merged commit e011c91 into stellar:master Sep 9, 2021
@bartekn bartekn deleted the split-update-ledger-state branch September 9, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split App.UpdateLedgerState into Core and Horizon ledger update methods
2 participants