Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Soft delete liquidity pools #3898

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Sep 8, 2021

This PR implements the following two changes which are required for #3836 :

  • Add a deleted column to the liquidity_pools table which we'll use to soft delete liquidity pool rows
  • Periodically prune deleted rows in CompactLiquidityPools()

In a subsequent PR, the in memory orderbook will use GetUpdatedLiquidityPools() to poll for changes to any liquidity pools and apply those changes to its in-memory data structures.

@tamirms tamirms requested a review from a team September 8, 2021 09:30
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tamirms tamirms merged commit 7d48db8 into stellar:amm Sep 8, 2021
@tamirms tamirms deleted the pool-compaction branch September 8, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants