Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Update TestProtocol14StateVerifier to test LiquidityPoolEntry #3867

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Aug 27, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Update TestProtocol14StateVerifier with Liquidity Pool entry to ensure state verifier works correctly. Rename TestProtocol14StateVerifier to TestStateVerifier and use the latest supported protocol version instead of 15.

Close #3839.

@bartekn bartekn requested a review from a team August 27, 2021 21:39
@bartekn bartekn linked an issue Aug 27, 2021 that may be closed by this pull request
Copy link
Contributor

@tamirms tamirms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. I think we can keep the state verifier integration test pretty basic (just create 1 of each ledger entry type) because we have https://github.com/stellar/go/blob/amm/services/horizon/internal/ingest/verify_test.go which which is a more extensive test of the state verifier

@bartekn bartekn merged commit bab2a22 into stellar:amm Aug 30, 2021
@bartekn bartekn deleted the test-state-verify-p18 branch August 30, 2021 11:30
@bartekn
Copy link
Contributor Author

bartekn commented Aug 30, 2021

Cool! I haven't noticed verify_test.go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TestProtocol14StateVerifier test to include liquidity pools
2 participants