Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add missing tx result codes #3866

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Aug 27, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

Added a new Protocol 18 and missing codes from previous protocol upgrade. Added a test to ensure return codes of all specific operation types are implemented.

Close #3858.

@bartekn bartekn requested a review from a team August 27, 2021 20:33
@bartekn bartekn linked an issue Aug 27, 2021 that may be closed by this pull request
@bartekn
Copy link
Contributor Author

bartekn commented Aug 30, 2021

@stellar/horizon-committers bump. I rely on this in integration tests. Can we merge?

@bartekn bartekn merged commit bbf030e into stellar:amm Aug 30, 2021
@bartekn bartekn deleted the missing-result-codes branch August 30, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new result codes in horizon/codes package
2 participants