Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add /liquidity_pools endpoint #3860

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Aug 26, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Adds implementation of /liquidity_pools endpoint.

Close #3831.

Why

New endpoint for CAP-38.

Known limitations

I based my code on /claimable_balances which implements the cursors of form [ledger_seq]-[id]. I'm not really sure why we are doing this like this because it won't make the paginated view consistent. For simplicity the cursors here are just IDs.

@bartekn bartekn requested a review from a team August 26, 2021 20:44
@bartekn bartekn changed the title services/horion: Add /liquidity_pools endpoint services/horizon: Add /liquidity_pools endpoint Aug 26, 2021
@tamirms
Copy link
Contributor

tamirms commented Aug 26, 2021

For simplicity the cursors here are just IDs

yes, I agree. the cursor should just be the id. also because we don't have an index on the last modified ledger column. we only have indexes on id and the reserve assets.

@bartekn bartekn merged commit f9cff64 into stellar:amm Aug 27, 2021
@bartekn bartekn deleted the liquidity-pools-page-handler branch August 27, 2021 14:02
@bartekn bartekn linked an issue Aug 27, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement /liquidity_pools endpoint
2 participants