Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: Implement /liquidity_pools/{id}/{transactions,operations} endpoints #3848

Merged
merged 3 commits into from
Aug 30, 2021
Merged

services/horizon: Implement /liquidity_pools/{id}/{transactions,operations} endpoints #3848

merged 3 commits into from
Aug 30, 2021

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Aug 25, 2021 •
edited
Loading

Fixes #3833

  • DB Tests

@2opremio 2opremio marked this pull request as draft August 25, 2021 14:42
@2opremio 2opremio mentioned this pull request Aug 25, 2021
Merged
7 tasks
@2opremio 2opremio changed the title [WIP] Implement /liquidity_pools/{id}/{transactions,operations} [WIP] services/horizon: Implement /liquidity_pools/{id}/{transactions,operations} endpoints Aug 25, 2021
@2opremio 2opremio force-pushed the amm-query-ops-txs-by-liquidity-pool branch from 36ab66c to c3f081e Compare August 26, 2021 17:03
@2opremio 2opremio changed the title [WIP] services/horizon: Implement /liquidity_pools/{id}/{transactions,operations} endpoints services/horizon: Implement /liquidity_pools/{id}/{transactions,operations} endpoints Aug 26, 2021
@2opremio 2opremio marked this pull request as ready for review August 26, 2021 17:04
@2opremio
Copy link
Contributor Author

2opremio commented Aug 26, 2021 •
edited
Loading

This should be ready for review. After today's test discussion (context: #3856 ) I decided to not add action tests.

@2opremio 2opremio force-pushed the amm-query-ops-txs-by-liquidity-pool branch from fa4889d to dab2bd8 Compare August 26, 2021 17:26
@paulbellamy
Copy link
Contributor

paulbellamy commented Aug 27, 2021 •
edited
Loading

@2opremio re: failing tests, the first thing is that AssetA and AssetB are backwards here: https://github.com/stellar/go/blob/amm/services/horizon/internal/ingest/processors/effects_processor_test.go#L2829-L2830.

They need to be sorted.

See: #3865

@2opremio 2opremio force-pushed the amm-query-ops-txs-by-liquidity-pool branch from f775cb9 to 4b5803e Compare August 30, 2021 14:49
@2opremio
Copy link
Contributor Author

They need to be sorted.

Ah, so I guess I need to invert the order of the assets in the fixtures. Thanks

@2opremio 2opremio merged commit b08f053 into stellar:amm Aug 30, 2021
@2opremio 2opremio deleted the amm-query-ops-txs-by-liquidity-pool branch August 30, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

@bartekn bartekn bartekn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2opremio @paulbellamy @bartekn @tamirms