Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config #38

Merged
merged 2 commits into from
Feb 14, 2017
Merged

Fix config #38

merged 2 commits into from
Feb 14, 2017

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Feb 13, 2017 •
edited
Loading

This PR contains two commits:

  1. 4491b16 fixing federation server config file. Some fields didn't have valid:"optional" tag but govalidator requires all fields to have valid tags.
  2. b45f11d close Print a notice in federation server if port is equal 443 but no certificate files have been specified #36.

nullstyle
nullstyle approved these changes Feb 13, 2017
View reviewed changes
Copy link
Contributor

@nullstyle nullstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bartekn bartekn merged commit 6878ff6 into master Feb 14, 2017
@nullstyle nullstyle deleted the fix-config branch February 14, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nullstyle nullstyle nullstyle approved these changes

@jedmccaleb jedmccaleb Awaiting requested review from jedmccaleb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print a notice in federation server if port is equal 443 but no certificate files have been specified
2 participants
@bartekn @nullstyle