Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Fix DB metrics when replica enabled #3668

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jun 5, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit fixes the duplicate metrics in db.Session that prevents Horizon from starting.

Why

An attempt to run Horizon with read replica middleware results in an error:

panic: duplicate metrics collector registration attempted

@bartekn bartekn force-pushed the fix-replica-db-metrics branch from 85b8914 to 8d1e077 Compare June 5, 2021 13:52
@bartekn bartekn requested a review from a team June 7, 2021 12:32
@bartekn bartekn marked this pull request as ready for review June 7, 2021 12:32
@bartekn bartekn merged commit 2ca3f84 into master Jun 7, 2021
@bartekn bartekn deleted the fix-replica-db-metrics branch June 7, 2021 12:51
bartekn added a commit that referenced this pull request Jun 7, 2021
This commit fixes the duplicate metrics in `db.Session` that prevents Horizon
from starting.

An attempt to run Horizon with read replica middleware results in an error:

panic: duplicate metrics collector registration attempted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants