services/horizon: Fix reingestion for the history_{transaction,operation}_claimable_balances tables
#3661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
approved these changes
Jun 4, 2021
paulbellamy
force-pushed
the
3659/fix_reingestion
branch
3 times, most recently
from
2f2ff35 to
da5b03f
Compare
|
Ok, so had to update kahuna to get the tests passing again. Basically, just did a diff between the base-horizon.sql, and kahuna-horizon.sql and copied over the table/index setups/teardowns. @bartekn does that seem like the right approach here? Not really sure on the normal maintenance for those files... |
|
@paulbellamy I think that approach is fine. The scenarios are deprecated. |
added 5 commits
June 7, 2021 12:49
…for reingestion Fixes stellar#3659
paulbellamy
force-pushed
the
3659/fix_reingestion
branch
from
da5b03f to
ee37850
Compare
paulbellamy
pushed a commit
that referenced
this pull request
Jun 7, 2021
…tion}_claimable_balances` tables (#3661) * Update the db setup (migrations, tables, indexes, etc) for kahuna to match base * refactor DeleteRangeAll to simplify it * Also clear the history_*_claimable_balances tables in DeleteRangeAll for reingestion Fixes #3659 * Update changelog * Try with a map to clean up the loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Also delete the ranges from
history_{transaction,operation}_claimable_balancestables.Why
So that they don't get duplicate insertion conflicts when reingesting with existing claimable balance data.
Known limitations
I didn't add any tests for this yet. How to test reingestion generally needs a bit more thought (IMO) than I wanted to have scope in this PR.