services/horizon: Return 503 error in POST /transactions if Stellar-Core not synced #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
force-pushed
the
txsub-check-core-sync
branch
from
ad07680
to
eedcd1a
Compare
tamirms
reviewed
Jun 4, 2021
7 tasks
tamirms
approved these changes
Jun 4, 2021
7 tasks
bartekn
added a commit
that referenced
this pull request
Jun 15, 2021
Adds sanity integration test for txsub. Add a test (`submit_transaction_test.go`) I forgot to include in #3653. While we have some unit tests for txsub we don't test the transaction submission endpoint during mirroring test. A simple integration test should at least catch the most obvious bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit changes
POST /transactionsbehaviour to return503 Service Unavailable(stale_history) instead of504 Gateway Timeout(timeout) response if connected Stellar-Core is not synced.Close #3550.
Why
timeouterror is confusing when the connected Stellar-Core is not synced because it means that the transaction has been broadcasted but there is no result yet. What actually happens is that the transaction is not broadcasted (and Horizon cannot ingest it) when Stellar-Core is not in synced. The new response is returned as soon as Horizon determines that the Stellar-Core status has changed.Known limitations
[TODO or N/A]