Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal: Deprecate captive-core-config-append-path #3629

Merged
merged 2 commits into from
May 25, 2021

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented May 25, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Deprecate --captive-core-config-append-path in favor of --captive-core-config-path. The difference between the two is that when --captive-core-config-path is used Horizon will validate the configuration file to reject any fields which are not supported by captive core.

Close #3442

@tamirms tamirms force-pushed the captive-core-config-path branch 2 times, most recently from 3be7eaa to 1e5919e Compare May 25, 2021 12:12
@tamirms tamirms requested a review from a team May 25, 2021 12:12
@tamirms tamirms force-pushed the captive-core-config-path branch 2 times, most recently from 9c58412 to 5ba852d Compare May 25, 2021 12:15
@tamirms tamirms force-pushed the captive-core-config-path branch from 5ba852d to 0793419 Compare May 25, 2021 12:19
@tamirms tamirms merged commit 6a32680 into stellar:master May 25, 2021
@tamirms tamirms deleted the captive-core-config-path branch May 25, 2021 14:50
@ire-and-curses
Copy link
Member

@paulbellamy Let's make sure we clearly identify this deprecation in the changelog and release notes. I know it's not breaking but we should tell people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add toml file specifically for captive core
3 participants