services/horizon: Apply and check migrations on ingesting instances only #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
approved these changes
May 5, 2021
bartekn
added a commit
that referenced
this pull request
May 5, 2021
…nly (#3586) This commit reverts 7c92b23 and changes the DB migrations behaviour to only trigger on ingesting instances. When checking if there are any migrations required Horizon calls `migrate.PlanMigration` which sends `CREATE TABLE gorp_migrations`. This write query is forbidden when using read only database (like replica). The new flag in 7c92b23 added unnecessary complexity. Ingesting instances are guaranteed to have write access to a DB. Thanks @jacekn for the idea!
sreuland
pushed a commit
to sreuland/go
that referenced
this pull request
Aug 7, 2022
…nly (stellar#3586) This commit reverts 7c92b23 and changes the DB migrations behaviour to only trigger on ingesting instances. When checking if there are any migrations required Horizon calls `migrate.PlanMigration` which sends `CREATE TABLE gorp_migrations`. This write query is forbidden when using read only database (like replica). The new flag in 7c92b23 added unnecessary complexity. Ingesting instances are guaranteed to have write access to a DB. Thanks @jacekn for the idea!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit reverts 7c92b23 and changes the DB migrations behaviour to only trigger on ingesting instances.
Why
When checking if there are any migrations required Horizon calls
migrate.PlanMigrationwhich sendsCREATE TABLE gorp_migrations. This write query is forbidden when using read only database (like replica).The new flag in 7c92b23 added unnecessary complexity. Ingesting instances are guaranteed to have write access to a DB.
Thanks @jacekn for the idea!
Known limitations
[TODO or N/A]