Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add 1s timeout to horizon.App.Tick #3567

Merged
merged 2 commits into from
Apr 26, 2021

Conversation

paulbellamy
Copy link
Contributor

Fixes #3344

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add 1s timeout to total runtime of horizon.App.Tick.

Why

See #3344

Known limitations

Just a single timeout, not per-item. But that seems to make sense given we want them all to complete within 1s total.

@paulbellamy paulbellamy requested a review from a team April 23, 2021 17:25
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should just increase the duration.

services/horizon/internal/app.go Outdated Show resolved Hide resolved
@paulbellamy paulbellamy merged commit 2348575 into stellar:master Apr 26, 2021
@paulbellamy paulbellamy deleted the 3344/tick-timeouts branch April 26, 2021 15:11
bartekn added a commit that referenced this pull request Jul 23, 2021
This commit moves ledger reaping service outside global `Tick()` method.

After #3567 reap process was cancelled after 1s. However in some deployments
removing older ledgers take more time. To prevent the process from being
cancelled in `Tick` it was moved outside of this method to a separate service.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeouts to all functions called from Tick()
4 participants