Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizon: Test consistency and coverage of effect typenames (and cleanup unused effects) #3562

Merged

Conversation

2opremio
Copy link
Contributor

Part of #3430

@2opremio 2opremio requested a review from a team April 22, 2021 10:20
@2opremio 2opremio force-pushed the 3430-test-coverage-of-effect-switches branch from 2d3920b to 618d917 Compare April 22, 2021 10:28
// EffectAccountInflationDestinationUpdated effects occur when an account changes its
// inflation destination.
EffectAccountInflationDestinationUpdated EffectType = 7 // from set_options
// EffectAccountInflationDestinationUpdated EffectType = 7 // from set_options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Horizon is producing it here:

if op.InflationDest != nil {
e.add(source.Address(), history.EffectAccountInflationDestinationUpdated,
map[string]interface{}{
"inflation_destination": op.InflationDest.Address(),
},
)
}

I think it's worth keeping the value here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good catch, thanks @bartekn

@2opremio 2opremio force-pushed the 3430-test-coverage-of-effect-switches branch from 618d917 to 483a690 Compare April 26, 2021 17:31
@2opremio 2opremio merged commit 10afb0a into stellar:master Apr 26, 2021
@2opremio 2opremio deleted the 3430-test-coverage-of-effect-switches branch April 26, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants