services/horizon: Add flag to choose a custom peering port for Captive Core #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
reviewed
Mar 23, 2021
tamirms
approved these changes
Mar 23, 2021
bartekn
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This introduces the
--captive-core-peer-port=11625parameter, which allows users to control which port Captive Core binds to when joining the Stellar network swarm.Why
Closes #3441.
Known limitations
No validation is done on the actual value passed in (aside from type == uint), so non-port values work. However, then Core will fail to start (with an appropriate error message, of course). We could try to "fail fast" instead, but we don't do this for the HTTP port either.