services/horizon: Add flag to customize storage directory for Captive Core data #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
force-pushed
the
custom-bucket-dir
branch
from
b76d848
to
d0cbf96
Compare
…lative (just like most things in life)
tamirms
reviewed
Mar 23, 2021
bartekn
reviewed
Mar 23, 2021
bartekn
approved these changes
Mar 24, 2021
Shaptic
force-pushed
the
custom-bucket-dir
branch
from
f3a677e
to
32e72c6
Compare
|
I swear if I need to merge master and pass tests before merging one more friggin' time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This introduces the
--captive-core-storage-path=./parameter, which allows users to control where Horizon stores Captive Core's data. This includes the auto-generated configuration, the log, and most-importantly Core's bucket data.It defaults to the current directory rather than
/tmpin order to raise visibility of the large amount of data Core stores in that directory. Internally,/captive-coreis appended to it since we wipe the directory on shutdown.Why
Closes #3437.
Known limitations
n/a