Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Improve Captive Stellar-Core validation #3477

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Mar 19, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit improves Captive Stellar-Core flags validation:

Why

Some users need hints how to configure Captive Stellar-Core.

Known limitations

This change can break some scripts that pass extra config flags without setting --ingest.

@bartekn bartekn requested a review from a team March 19, 2021 13:20
@bartekn bartekn merged commit 181921f into stellar:master Mar 19, 2021
@bartekn bartekn deleted the improve-captive-config-validation branch March 19, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants