services/horizon: Stop generating separate Captive Core logs. #3463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Passes along
LOG_FILE_PATH=""
to Stellar Core so that there is no separate log file.Why
Closes #3438: the log file is unnecessary since Horizon already (re)logs all of Core's output as the
stellar-core
subservice. This also saves space in the system's/tmp
directory.Known limitations
This is not customizable.
The original issue #3438 asks for adding a parameter to customize the output log (e.g. something like
--captive-core-log-path
), but after the clarifications, it's unclear whether or not there's an active need in storing a separate log at all. If this is still an ask, it will be trivial to expand this PR.