Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Fix fee stats with effective operation count when fee bump #3354

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jan 18, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit fixes /fee_stats query. It also rewrites the query to use text/template to prevent typos and make the query more readable.

Close #3341.

Why

The previous query did not take effective operation count when calculating stats. When fee bump transaction is added to a ledger, it has an effective number of operations equal to one plus the number of operations in the inner transaction.

@cla-bot cla-bot bot added the cla: yes label Jan 18, 2021
@bartekn bartekn requested a review from a team January 18, 2021 17:26
@bartekn bartekn merged commit 3008d64 into stellar:master Jan 19, 2021
@bartekn bartekn deleted the fix-fee-stats-effective-fee branch January 19, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take effective number of operations in /fee_stats into account when fee_bump transaction in a ledger
2 participants