Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Fix fee stats calculations when fee bump transaction in the ledger #3326

Merged

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jan 11, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

This commit fixes a bug in fee stats calculations. When fee bump transactions is included in the ledger the max_fee value was taken from inner transaction, instead of fee bump transaction.

Fix #3316.

Known limitations

I updated scenario files manually because of the problems running scc.

@bartekn bartekn requested a review from a team January 11, 2021 12:38
@cla-bot cla-bot bot added the cla: yes label Jan 11, 2021
@bartekn bartekn merged commit 599b056 into stellar:release-horizon-v1.13.1 Jan 11, 2021
@bartekn bartekn deleted the fix-fee-stats-fee-bump branch January 11, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid fee_stats calculations when fee_bump transaction is included in the ledger
2 participants