services/horizon/internal/test/integration: Run captive core integration tests #3291
Conversation
tamirms
force-pushed
the
captive-core-integration-tests
branch
8 times, most recently
from
bd6dccb to
190b8da
Compare
tamirms
force-pushed
the
captive-core-integration-tests
branch
from
190b8da to
75a4876
Compare
| # From "SACJC372QBSSKJYTV5A7LWT4NXWHTQO6GHG4QDAVC2XDPX6CNNXFZ4JK" | ||
| PUBLIC_KEY="GD5KD2KEZJIGTC63IGW6UMUSMVUVG5IHG64HUTFWCHVZH2N2IBOQN7PS" | ||
| ADDRESS="localhost" | ||
| QUALITY="MEDIUM" |
There was a problem hiding this comment.
Do we need a config file for reingestion?
There was a problem hiding this comment.
we need to set ARTIFICIALLY_ACCELERATE_TIME_FOR_TESTING=true to be compatible with the stellar core container which is running the stand alone network.
The quorum set has no significance since we'll be doing reingestion which relies only on the history archives. But stellar-core still requires a non empty quorum set for the configuration file to be valid so I cannot leave the section empty.
There was a problem hiding this comment.
I wonder if we can add another stellarCoreRunnerMode: stellarCoreRunnerModeOfflineIntegrationTests that would generate config with the value set. Not urgent and maybe not needed so just sharing an idea.
There was a problem hiding this comment.
@bartekn another possibility is to have stellarCoreRunner set ARTIFICIALLY_ACCELERATE_TIME_FOR_TESTING=true in the config if the CheckpointFrequency in the captive core config is equal to 8.
services/horizon/docker/captive-core-reingest-range-integration-tests.cfg
Outdated
Show resolved
Hide resolved
| func (i *Test) RestartHorizon() { | ||
| i.app.Close() | ||
|
|
||
| // wait for horizon to shut down completely | ||
| time.Sleep(time.Second) | ||
|
|
||
| i.startHorizon( | ||
| i.horizonConfig.CaptiveCoreBinaryPath, | ||
| i.horizonConfig.CaptiveCoreConfigAppendPath, | ||
| i.horizonConfig.DatabaseURL, | ||
| false, | ||
| ) | ||
| i.waitForHorizon() | ||
| } |
| "--captive-core-config-append-path", | ||
| captiveCoreConfigPath, | ||
| "--captive-core-http-port", | ||
| "0", |
There was a problem hiding this comment.
If this is because it clashes with the http port of the other core instance, I think it's worth commenting it.
There was a problem hiding this comment.
Can we run two cores at the same time in integration tests? We shouldn't, right?
|
BTW, huge thanks for getting this done 🥳 I think it's a big milestone for testing captive core! |
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit adds a CircleCI job so that the integration tests are run twice (once with captive core enabled and the other time with captive core disabled) for every PR.
The integration tests with captive core enabled are about 1.5 minutes slower than running the tests with captive core disabled.
Known limitations
[N/A]