all: Parameterize the checkpoint frequency #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
changed the title
2opremio
force-pushed
the
configurable-checkpoint
branch
from
19552a7 to
40edbd4
Compare
Shaptic
reviewed
Dec 8, 2020
2opremio
changed the title
2opremio
force-pushed
the
configurable-checkpoint
branch
2 times, most recently
from
51ea53e to
17be8ef
Compare
tamirms
reviewed
Dec 9, 2020
tamirms
reviewed
Dec 9, 2020
|
PTAL |
tamirms
approved these changes
Dec 12, 2020
It used to be hardcoded to 64 (whcih is what _normal_ Stellar Core). However, when using ARTIFICIALLY_ACCELERATE_TIME_FOR_TESTING in integration tests, the frequency is reduced to 8.
2opremio
force-pushed
the
configurable-checkpoint
branch
from
7926537 to
d91c315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be hardcoded to 64 (which is what normal Stellar Core).
However, when using ARTIFICIALLY_ACCELERATE_TIME_FOR_TESTING in integration tests, the frequency is reduced to 8.
Followup to #3264