Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/docker: Remove RUN_STANDALONE=true from stellare-core-standalone.cfg #3271

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Dec 8, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Remove RUN_STANDALONE=true from the stand alone configuration for the docker compose setup.

Why

When RUN_STANDALONE is set to true it prevents stellar core from accepting any peer connections. This prevents you from running a stand alone network with multiple core nodes. This also makes it impossible to run horizon with captive core on the stand alone network.

Known limitations

[N/A]

@tamirms tamirms requested a review from a team December 8, 2020 09:34
@cla-bot cla-bot bot added the cla: yes label Dec 8, 2020
@tamirms tamirms merged commit 83330cb into stellar:master Dec 8, 2020
@tamirms tamirms deleted the fix-standalone-config branch December 8, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants