ingest/ledgerbackend: Remove returning error on Stellar-Core process exit during catchup #3260
Conversation
| @@ -99,6 +99,10 @@ func (b *bufferedLedgerMetaReader) readLedgerMetaFromPipe() (*xdr.LedgerCloseMet | |||
| // Wait for LedgerCloseMeta buffer to be cleared to minimize memory usage. | |||
| select { | |||
| case <-b.runner.getProcessExitChan(): | |||
| if untilSequence != 0 { | |||
There was a problem hiding this comment.
we also handle <-b.runner.getProcessExitChan a few lines below. Should we also have a untilSequence != 0 check in that block of code?
There was a problem hiding this comment.
looks like getProcessExitChan() is handled a few lines above as well
There was a problem hiding this comment.
We only handle the other instances of getProcessExitChan if an error occurs (so it ignores cases when core is done but there are still ledgers in a buffer). However, I think there's a bug. In for frameLength > metaPipeBufferSize && len(b.c) > 0 we should return an error if core was closed with an error. Going to add it in a new commit.
There was a problem hiding this comment.
OK fixed in aecfd75.
There was a problem hiding this comment.
do we still need to worry about the case where len(b.c) > 0 but frameLength <= metaPipeBufferSize ?
There was a problem hiding this comment.
In such case (and on Core exit) we won't enter into a for loop but the xdr.Unmarshal below will error and we will handle the error there.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
Fixes a bug introduced in a10c000 because of which
PrepareRangeandGetLedgermethods could return an error after Stellar-Core process exit but before all ledgers are read from the buffer. To fix it we now handle process exit inbufferedLedgerMetaReaderonly and only in case of errors. InPrepareRangewe return error only on Stellar-Core exit with error. This won't work with user initiated shutdown, it will be fixed in #3258.Thanks for the report, @Isaiah-Turner!