Merge release-horizon-v1.12.0 into master #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes off-by-one bug in `CaptiveStellarCore.runFromParams`. In 21e076a a `TrustedLedgerHashStore` interface was added and used in `CaptiveStellarCore`. However, due to copy-paste the `GetLedgerHash` method was called with a wrong param (`from` instead of `from-1`). This happened because similar call to `archive.GetLedgerHeader` was copied however, in this call we use a `PreviousLedgerHash` instead.
This commit correctly sets the log level in the captive core api logger. With this fix the captive core api logs are now visible and formatted correctly. This commit also marks the active request as invalid whenever a captive core function returns an error. By marking the active request as invalid we ensure that the captive core subprocess is recreated the next time POST /prepare-range is invoked.
2opremio
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@2opremio doing this sooner because I want to test #3249 makes any difference in stg.