Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Trivial improvements to Stellar Core log parsing #3237

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Nov 20, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Improves log output:

  • Infof -> Info for non-formatted strings
  • Lines w/o pubkey prefix are parsed correctly

Why

When the line from Stellar Core's logs contains %, it's interpreted as a formatting directive by the output function (e.g. Infof), causing extraneous output. It should just use Info to avoid this.

Not all Core lines begin with a public key prefix G[AB12] (e.g. ones that begin with <startup> instead), so we shouldn't enforce this in the regex.

@Shaptic Shaptic requested a review from a team November 20, 2020 01:32
@Shaptic Shaptic self-assigned this Nov 20, 2020
@cla-bot cla-bot bot added the cla: yes label Nov 20, 2020
@Shaptic Shaptic merged commit f1c5d71 into stellar:master Nov 23, 2020
@Shaptic Shaptic deleted the logfmt-fix branch November 23, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants