services/horizon: Update integration tests to use MANUAL_CLOSE #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Core's `MANUAL_CLOSE` mode in integration tests so that we don't have to wait for ledgers to be closed (we close them explicitly). This paves the way for enabling integration tests for Captive Core.
2opremio
force-pushed
the
integration-manual-close
branch
from
3016153 to
cccbe0b
Compare
bartekn
approved these changes
Oct 28, 2020
| // blocks until the transaction is in a closed ledger | ||
| go func() { | ||
| // This sleep is ugly, but a better approach would probably require | ||
| // instrumenting Horizon to tell us when the transaction was sent to core. |
There was a problem hiding this comment.
Nit: we can start 2 go routines:
- First one with
SubmitTransactionXDRthat will write to unbuffered channel when done. - Second that closes core ledgers in an infinite loop with a
selectstatement with 2 cases: a)time.After, b) on a unbuffered channel from previous point.
This way when submission is done, second go routine will escape (unbuffered channel), but if not it will close another ledger after some time.
There was a problem hiding this comment.
Ops, I saw this after merging. I will incorporate it later, thanks.
Comment on lines
+642
to
+644
| ctx, cancel := context.WithTimeout(context.Background(), time.Second) | ||
| defer cancel() | ||
| return i.cclient.ManualClose(ctx) |
There was a problem hiding this comment.
Logging can be helpful with debugging.
Suggested change
| ctx, cancel := context.WithTimeout(context.Background(), time.Second) | |
| defer cancel() | |
| return i.cclient.ManualClose(ctx) | |
| i.t.Log("Closing ledger manually...") | |
| ctx, cancel := context.WithTimeout(context.Background(), time.Second) | |
| defer cancel() | |
| return i.cclient.ManualClose(ctx) |
There was a problem hiding this comment.
Note taken, thanks.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use Core's
MANUAL_CLOSEmode in integration tests so that we don't have to wait for ledgers to be closed (we close them explicitly).Why
It considerably reduces the execution time of integration tests (From ~13min to ~5min).
Also, it paves the way for enabling integration tests for Captive Core (#3153) and contributes towards #3037 .
Known limitations
We are changing the timing in which the production network operates, which makes the tests deviate from a production scenario.