clients/stellarcore: Add Manual Close endpoint to Core's client #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for
MANUAL_CLOSEendpoint to the Stellar Core HTTP client.Why
We plan to use
MANUAL_CLOSEin the Horizon Captive Core integration tests. In particular need to quickly close the first 64 ledgers in order to reach the first ledger endpoint and avoid waiting for 5 minutes in each test. More context here #3144 (comment)Later on this will come handy to close ledgers right after submitting a transaction, which will remove the remaining waiting time in integration tests.
Known limitations
N/A