services/horizon: Fix captive-core's reset of its tmp dir #3154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix how the Captive Core backend resets its temporary directory. Previously:
close()
Why
It made Captive core enter an error loop after a reset was attempted (e.g. after encountering an unexpected state).
Fixes #3145
Known limitations
It may be cleaner to just create another runner instead of just expecting
stellarCoreRunner
to work after a call toclose()
(which is how it is today).