Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Fix captive-core's reset of its tmp dir #3154

Closed
wants to merge 1 commit into from

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Oct 22, 2020

What

Fix how the Captive Core backend resets its temporary directory. Previously:

  • it removed its contents, but didn't reset its reference to the path.
  • it didn't re-create the temporary directory after close()

Why

It made Captive core enter an error loop after a reset was attempted (e.g. after encountering an unexpected state).

Fixes #3145

Known limitations

It may be cleaner to just create another runner instead of just expecting stellarCoreRunner to work after a call to close() (which is how it is today).

@2opremio 2opremio requested a review from a team October 22, 2020 17:11
@cla-bot cla-bot bot added the cla: yes label Oct 22, 2020
@2opremio 2opremio changed the title Fix captive-core's reset of its tmp dir services/horizon: Fix captive-core's reset of its tmp dir Oct 22, 2020
@2opremio 2opremio force-pushed the captive-core-reset-tmpdir branch from 376567c to c805abe Compare October 22, 2020 17:37
@2opremio
Copy link
Contributor Author

It may be cleaner to just create another runner instead of just expecting stellarCoreRunner to work after a call to close() (which is how it is today).

It is much cleaner (and there was a bug preventing this from happening).

I created #3162 , which overrides this PR (sorry @bartekn )

@2opremio 2opremio closed this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Captive Core's temporary db directory disappears breaking execution
2 participants