services/horizon: Export ledger stats in /metrics, add claimable_balance to change stats #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce to change stats
Shaptic
reviewed
Oct 21, 2020
| @@ -82,6 +95,10 @@ func (stats *StatsChangeProcessorResults) Map() map[string]interface{} { | |||
| "stats_accounts_updated": stats.AccountsUpdated, | |||
| "stats_accounts_removed": stats.AccountsRemoved, | |||
|
|
|||
| "stats_claimable_balances_created": stats.ClaimableBalancesCreated, | |||
| "stats_claimable_balances_updated": stats.ClaimableBalancesUpdated, | |||
| "stats_claimable_balances_removed": stats.ClaimableBalancesRemoved, | |||
There was a problem hiding this comment.
Do we want to extend the CB integration tests to check these new fields, or do you think unit tests are sufficient?
There was a problem hiding this comment.
I'm not sure we have any tests for this so far. If we want to add some integration tests, I'd vote for adding this in another PR.
2opremio
reviewed
Oct 22, 2020
Comment on lines
476
to
491
|
|
||
| // Update stats metrics | ||
| changeStatsMap := changeStats.Map() | ||
| for stat, value := range changeStatsMap { | ||
| stat = strings.Replace(stat, "stats_", "change_", 1) | ||
| s.Metrics().LedgerStatsCounter. | ||
| With(prometheus.Labels{"type": stat}).Add(float64(value.(int64))) | ||
| } | ||
|
|
||
| ledgerTransactionStatsMap := ledgerTransactionStats.Map() | ||
| for stat, value := range ledgerTransactionStatsMap { | ||
| stat = strings.Replace(stat, "stats_", "ledger_", 1) | ||
| s.Metrics().LedgerStatsCounter. | ||
| With(prometheus.Labels{"type": stat}).Add(float64(value.(int64))) | ||
| } | ||
|
|
There was a problem hiding this comment.
would it be worth to factor out the metrics-updating code? (the method is already pretty large)
2opremio
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Export ledger stats (number of ops and changes) in
/metrics. Add claimable balances to changes stats.Close #3133.
Why
To be able to correlate slow ledger with network activitity.