Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp/ingest: Move exp/ingest package to top level and rename expingest to ingest #3118

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Oct 9, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Close #2851

Move exp/ingest package to top level and rename expingest to ingest.

Why

The new Horizon ingestion implementation has been running in production for over 6 months.
We are confident that we can remove the experimental warning from the ingestion implementation.

Known limitations

[N/A]

@cla-bot cla-bot bot added the cla: yes label Oct 9, 2020
@tamirms tamirms requested a review from a team October 9, 2020 17:52
@tamirms tamirms removed the request for review from a team October 9, 2020 19:21
@tamirms tamirms force-pushed the move-ingest branch 3 times, most recently from c777f08 to da25083 Compare October 13, 2020 12:06
@tamirms tamirms requested a review from a team October 13, 2020 12:14
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should add the change of service label in the logs to CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename expingest to ingest
2 participants