exp/services/webauth: remove the stellar.toml domain checks #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What Remove the stellar.toml domain checks that occur on application start. Essentially revert the changes relating to this specific feature that were introduced in 5e82f16. ### Why SEP-10 v2.0.0 highlighted an existing feature that the SIGNING_KEY field in the stellar.toml be the key that the SEP-10 server uses for signing. In 5e82f16 we added the feature that the server would verify that the stellar.toml that references the SEP-10 server. This feature is inconvenient because not all SEP-10 services have a stellar.toml. It's also scope creep on what this SEP-10 server implementation is concerned with.
JakeUrban
approved these changes
Oct 8, 2020
|
How different is this change from a simple revert of the original commit that introduced this change? UPDATE: Oh I see, the original commit included the SEP-20 change in the txbuild package too. |
|
It should be identical unless I made a mistake. The original change being reverted was bundled with other changes and so I didn't want to revert all of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Remove the stellar.toml domain checks that occur on application start. Essentially revert the changes relating to this specific feature that were introduced in 5e82f16.
Why
SEP-10 v2.0.0 highlighted an existing feature that the
SIGNING_KEYfield in thestellar.tomlbe the key that the SEP-10 server use for signing. In 5e82f16 we added the feature that the server would verify that the stellar.toml that references the SEP-10 server contains the correct key. This feature is inconvenient because not all SEP-10 services have a stellar.toml. It's also inconvenient when developing. It's also scope creep on what this SEP-10 server implementation is concerned with. It also delays service boot up time which ideally should not block on external services. If we need tools for validating or verifying stellar.toml's we should probably pursue that as a separate tool.Known limitations
This is a breaking change because it removes a config parameter, but the services is experimental and we can make breaking changes. For any service using environment variables to provide the config this will not be a breaking change and the additional config will be ignored.