Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Allow using captive core in integration tests #3107

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Oct 7, 2020

To do so, you need to set the HORIZON_INTEGRATION_ENABLE_CAPTIVE_CORE env variable to any value (e.g. true).

To do so, you need to set the
`HORIZON_INTEGRATION_ENABLE_CAPTIVE_CORE` env variable
to any value (e.g. `true`).
@2opremio 2opremio requested a review from a team October 7, 2020 23:10
@cla-bot cla-bot bot added the cla: yes label Oct 7, 2020
@2opremio 2opremio changed the title Allow using captive core in integration tests services/horizon: Allow using captive core in integration tests Oct 7, 2020
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that it works out of the box! Can we add it to Circle-CI config to start another integrations tests job with captive core enabled?

@2opremio
Copy link
Contributor Author

2opremio commented Oct 8, 2020

Yep, I am working on a separate PR for that.

@2opremio 2opremio merged commit 34bf6a5 into stellar:master Oct 8, 2020
@2opremio 2opremio deleted the allow-captive-core-itests branch October 8, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants