services/horizon: Wrap invalid cursor in claimable balances in problem.P #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
commented
Oct 2, 2020
| historyQ, err := horizonContext.HistoryQFromRequest(r) | ||
| if err != nil { | ||
| return nil, err | ||
| return nil, problem.MakeInvalidFieldProblem("query parameters", err) | ||
| } |
We do cursor validation, however, if there is an error we return a plain error instead of a `problem.P` -- this causes horizon to handle the error as a 500 instead of a 400. This fix moves cursor parsing to its own method and then use it in the query handler to return a `problem.P` error. Fixes stellar#3085.
abuiles
force-pushed
the
fix-claimable-balance-invalid-cursor-error
branch
from
67bdb8c to
52b6649
Compare
tamirms
approved these changes
Oct 2, 2020
bartekn
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Wrap invalid cursor in claimable balances in
problem.PWhy
We do cursor validation, however, if there is an error we return a
plain error instead of a
problem.P-- this causes horizon to handlethe error as a
500instead of a400.This fix moves cursor parsing to its own method and then use it in the
query handler to return a
problem.Perror which causes horizon toreturn the correct response.
I opted to create a new error instead of returning the inner error
since it exposes low-level details which are not relevant for the API
user, for example:
Invalid cursor - first value should be higher than 0: strconv.ParseInt: parsing \"\": invalid syntaxInvalid cursor - second value should be a valid claimable balance id: xdr:decode: switch '67' is not valid enum value for unionFixes #3085.
Known limitations