Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txnbuild: Fix bug in parsing transactions with Protocol 14 operations #3087

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Oct 2, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

There was a bug which occurred when parsing transaction XDR strings which contained protocol 14 operation. This PR fixes the bug and adds test to ensure that all Protocol 14 operations can be parsed correctly.

@cla-bot cla-bot bot added the cla: yes label Oct 2, 2020
@tamirms tamirms requested a review from a team October 2, 2020 08:25
@tamirms tamirms merged commit 10d1362 into stellar:master Oct 2, 2020
@tamirms tamirms deleted the fix-txnbuild branch October 2, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants