historyarchive: Check archive's network passphrase when getting HAS #3082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add a code comparing network passphrase in HAS with expected network passphrase.
Why
Stellar-Core 14.1.0 started publishing network passphrase in HAS (stellar/stellar-core#2579). Checking this value will help debug connecting to incorrect history archive faster. In the past one of Horizon users used pubnet config (connected to pubnet Stellar-Core) but testnet archive. Because of that Horizon was waiting indefinitely for a checkpoint ledger after a given pubnet ledger but it never appeared because testnet ledger sequence numbers are much smaller than in pubnet.
Known limitations
The values are compared when getting HAS. Ideally, it should be checked in
Connect
but this would send an HTTP request.