Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

historyarchive: Check archive's network passphrase when getting HAS #3082

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Oct 1, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Add a code comparing network passphrase in HAS with expected network passphrase.

Why

Stellar-Core 14.1.0 started publishing network passphrase in HAS (stellar/stellar-core#2579). Checking this value will help debug connecting to incorrect history archive faster. In the past one of Horizon users used pubnet config (connected to pubnet Stellar-Core) but testnet archive. Because of that Horizon was waiting indefinitely for a checkpoint ledger after a given pubnet ledger but it never appeared because testnet ledger sequence numbers are much smaller than in pubnet.

Known limitations

The values are compared when getting HAS. Ideally, it should be checked in Connect but this would send an HTTP request.

@bartekn bartekn requested a review from a team October 1, 2020 10:47
@cla-bot cla-bot bot added the cla: yes label Oct 1, 2020
@bartekn bartekn merged commit 6323e73 into stellar:master Oct 1, 2020
@bartekn bartekn deleted the historyarchive-network-check branch October 1, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants