services/horizon: Add integration tests for predicates on claimable balances. #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaptic
changed the title
Shaptic
commented
Sep 17, 2020
| _, accountB, _ := accounts[0], accounts[1], accounts[2] | ||
|
|
||
| // This is an easy fail. | ||
| predicate := txnbuild.NotPredicate(&txnbuild.UnconditionalPredicate) |
There was a problem hiding this comment.
Why would we ever want a predicate that always fails?
- me like a week ago 😂 (cc @tamirms)
Shaptic
force-pushed
the
predicate-tests
branch
from
89b2ce6 to
98f364a
Compare
abuiles
approved these changes
Sep 17, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This adds tests for predicates on claimable balances.
It first checks the happy paths, ensuring that all predicate types can be created and that valid predicates result in actually claimable balances.
It also checks that predicates actually matter: both an unconditionally-false predicate and an expiring timer cause the claimabe balance to be irretrievable.
Why
Further testing of CAP-23 (see #2939) and specifically of #3000.
(sorry about the weird commit history... should go away w/ squash & merge)