Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Revamps existing integration tests to run faster & be more modular. #3026

Merged
merged 31 commits into from
Sep 17, 2020

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Sep 16, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This PR revamps the claimable balance tests to run much faster, and also introduces some basic predicate tests.

The biggest change is that almost all tests are subtests, so the docker container is only created a single time for a large set of scenarios. This reduces risk of timeout errors, speeds up tests, and encourages better test practices.

Specifically,

  • the "filter & query" test is now a series of subtests
  • the "claim" tests are now shorter, more robust, and self-contained
  • "helper" methods are more modular and flexible

New predicate tests will come in another PR. This also resolves #3000.

Why

Tests are good, fast tests are better ❤️

Known limitations

n/a

Shaptic and others added 26 commits September 14, 2020 10:32
@cla-bot cla-bot bot added the cla: yes label Sep 16, 2020
@Shaptic Shaptic changed the title services/horizon: Predicate tests services/horizon: Revamps existing integration tests to run faster & be more modular. Sep 16, 2020
@Shaptic Shaptic requested review from abuiles and a team September 16, 2020 22:47
@Shaptic Shaptic self-assigned this Sep 16, 2020
@Shaptic Shaptic linked an issue Sep 16, 2020 that may be closed by this pull request
services/horizon/internal/test/integration.go Outdated Show resolved Hide resolved
@Shaptic Shaptic merged commit ed2eb93 into stellar:protocol-14 Sep 17, 2020
@Shaptic Shaptic deleted the modular-tests branch October 28, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to build Claimable Balance Predicate on txbuild?
2 participants