Fix static check tests. #3005
Merged
Fix static check tests. #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
commented
Sep 14, 2020
| // | ||
| // Note: The function panics if this account doesn't exist in the ledger yet, so | ||
| // be sure to fund it before doing this. | ||
| func (i *IntegrationTest) EstablishTrustline( |
There was a problem hiding this comment.
I think @Shaptic will add later this in a different PR, but for now, since we don't use it, let's remove it.
There was a problem hiding this comment.
Yep, this was used in the breaking claiming tests.
abuiles
commented
Sep 14, 2020
| @@ -1,3 +1,4 @@ | |||
| //lint:file-ignore U1001 Ignore all unused code, staticcheck doesn't understand testify/suite | |||
There was a problem hiding this comment.
In general we don't care about this internal txnbuild copy - so i removed a bunch of unused files and file-ignore in the new ones. We'll use them as we add more integration tests, but it doesn't really matter since eventually we'll remove these files in favor of the actual txnbuild
tamirms
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Fixes the CI by removing a bunch of unused code and adding an explicit skip in the places where we know the linter would fail even if the code is being used.
Why
Make CircleCI green again.
Known limitations
[TODO or N/A]