Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/txsub: Fix false positive bad sequence error when submitting transactions #2877

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Aug 3, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Close #2628

Horizon can respond with a false positive bad sequence error when Horizon's ingestion lags behind Stellar Core. To avoid sending back this misleading error we should check that Horizon's ingestion is consistent with Stellar Core before checking whether the transaction exists in the Horizon DB.

We are able to check that Horizon's DB is consistent with Stellar Core indirectly by observing the sequence number of the source account of the transaction. If the sequence number of the source account is below the sequence number set in the transaction, then we know Horizon is still behind Stellar Core. Once the sequence number equals or exceeds the transaction sequence number we know that we are consistent with Stellar Core at the point where Stellar Core returned the bad sequence error.

@tamirms tamirms requested a review from a team August 3, 2020 17:44
@cla-bot cla-bot bot added the cla: yes label Aug 3, 2020
@bartekn bartekn changed the base branch from master to release-horizon-v1.7.0 August 4, 2020 13:30
Copy link
Contributor

@bartekn bartekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should include it in 1.7.0 - I updated the base branch.

@bartekn
Copy link
Contributor

bartekn commented Aug 4, 2020

Please update CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizon returned bad sequence error although the transaction was added to ledger
2 participants