services/horizon/internal/txsub: Fix false positive bad sequence error when submitting transactions #2877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #2628
Horizon can respond with a false positive bad sequence error when Horizon's ingestion lags behind Stellar Core. To avoid sending back this misleading error we should check that Horizon's ingestion is consistent with Stellar Core before checking whether the transaction exists in the Horizon DB.
We are able to check that Horizon's DB is consistent with Stellar Core indirectly by observing the sequence number of the source account of the transaction. If the sequence number of the source account is below the sequence number set in the transaction, then we know Horizon is still behind Stellar Core. Once the sequence number equals or exceeds the transaction sequence number we know that we are consistent with Stellar Core at the point where Stellar Core returned the bad sequence error.