Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon/internal/db2/schema/migrations: Add constraints on database columns which cannot hold negative values #2827

Merged
merged 4 commits into from
Jul 21, 2020

Conversation

tamirms
Copy link
Contributor

@tamirms tamirms commented Jul 17, 2020

…values

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fixes #2605

Add constraints on database columns which can only hold non-negative values.

verify-range tests revealed a bug in which max_fee value of this transaction has overflowed. This happened because the type of this field in XDR Transaction struct definition was (before fee bump changes) uint32 but Postgres does not support unsigned integer types.

To catch this kind of errors faster we should add constraints to fields like max_fee. While this can stop ingestion on invalid value insert attempt it's safer.

@cla-bot cla-bot bot added the cla: yes label Jul 17, 2020
@tamirms tamirms requested a review from a team July 17, 2020 14:20
@tamirms tamirms merged commit 4700d3a into stellar:master Jul 21, 2020
@tamirms tamirms deleted the db-constraints branch July 21, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add constraints to biginteger fields that accept positive values only
3 participants