Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Ignore ConnectionTimeout in txsub #2818

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jul 15, 2020

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

This commit changes the behaviour of --connection-timeout config param. Right now, it is ignored in txsub so if the value is less than 30s, txsub will still timeout after 30s.

Why

If Horizon admin wants to set --connection-timeout to a small value it will likely affect txsub system because it requires at least 5 seconds on average to report the status of the transaction when it's included in the ledger.

Known limitations

Currently the code ignores timeout for all POST requests to avoid having to parse the route from request URL.

@cla-bot cla-bot bot added the cla: yes label Jul 15, 2020
@bartekn bartekn requested a review from a team July 15, 2020 13:38
Copy link
Contributor

@abuiles abuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bartekn bartekn merged commit 9af0422 into stellar:release-horizon-v1.6.0 Jul 15, 2020
@bartekn bartekn deleted the ignore-connection-timeout-in-txsub branch July 15, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants