txnbuild: Add ToXDR functions which do not return errors #2651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Add
ToXDR()
functions forTransaction
andFeeBumpTransaction
instances which return xdr transaction envelopes without errors.Why
The reason why
TxEnvelope()
returns an error is that it copies the internal transaction envelope by marshaling and unmarshaling the value. However, if we return a reference to the internal transaction we do not need to handle any error cases. Most users probably will not be modifying the contents of the returned transaction envelope. Having a function which returns a transaction envelope without a possible error is more ergonomic.Known limitations
[N/A]